Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v1 can be simplified for s3 images #368

Open
ondrejbudai opened this issue May 27, 2022 · 0 comments
Open

API v1 can be simplified for s3 images #368

ondrejbudai opened this issue May 27, 2022 · 0 comments
Assignees

Comments

@ondrejbudai
Copy link
Member

ondrejbudai commented May 27, 2022

Currently, if I want to create a guest-image, I must specify also the upload request:

{
  "distribution": "rhel-90",
  "image_requests": [
    {
      "architecture": "x86_64",
      "image_type": "guest-image",
      "upload_request": {
        "type": "aws.s3",
        "options": {}
      }
    }
  ]
}

The upload request is redundant though, the upload request type can be inferred from the image type (we always upload guest images into s3) and the options are always... empty.

Ideally, I would like to request the image with only:

{
  "distribution": "rhel-90",
  "image_requests": [
    {
      "architecture": "x86_64",
      "image_type": "guest-image"
    }
  ]
}

Much less typing, same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants