Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount /var/tmp in stages #223

Closed
cgwalters opened this issue Feb 29, 2024 · 6 comments
Closed

Mount /var/tmp in stages #223

cgwalters opened this issue Feb 29, 2024 · 6 comments

Comments

@cgwalters
Copy link
Contributor

cgwalters commented Feb 29, 2024 •
edited
Loading

Migrating CentOS/centos-bootc#375 here, see CentOS/centos-bootc#375 (comment)
@cgwalters cgwalters mentioned this issue Feb 29, 2024
Closed
@cgwalters
Copy link
Contributor Author

Basically the ostree code has special handling for hardlinks that kicks in in unusual situations, and it wants to allocate a tmpfile in /var/tmp, which doesn't exist in the bwrap invocation that osbuild uses.

@cgwalters
Copy link
Contributor Author

Ended up doing ostreedev/ostree-rs-ext#606 which will fix this, but I think we clearly want a /var/tmp in osbuild stages (that could just be a symlink to /tmp too)

@cgwalters
Copy link
Contributor Author

This one is a pretty high value, low risk issue and I believe should be easy to fix, I just don't quite know the osbuild code well enough yet to do it; any takers?

mvo5 added a commit to mvo5/osbuild that referenced this issue Mar 7, 2024
@mvo5
osbuild: ensure a usable /var/tmp is available inside the buildroot
579593e 
Colin asked for this in
osbuild/bootc-image-builder#223 and
it's easy enough.
@mvo5 mvo5 mentioned this issue Mar 7, 2024
Merged
@mvo5
Copy link
Collaborator

mvo5 commented Mar 7, 2024

Please have a look at osbuild/osbuild#1649 and let me know if that is what you have/had in mind.

mvo5 added a commit to mvo5/osbuild that referenced this issue Mar 7, 2024
@mvo5
osbuild: ensure a usable /var/tmp is available inside the buildroot
e1248a5 
Colin asked for this in
osbuild/bootc-image-builder#223 and
it's easy enough.
mvo5 added a commit to mvo5/osbuild that referenced this issue Mar 7, 2024
@mvo5
osbuild: ensure a usable /var/tmp is available inside the buildroot
5163ff0 
Colin asked for this in
osbuild/bootc-image-builder#223 and
it's easy enough.
@cgwalters
Copy link
Contributor Author

Attempted to push a test fixture for this here btw https://gitlab.com/bootc-org/tests/container-fixtures/-/merge_requests/7

ondrejbudai pushed a commit to osbuild/osbuild that referenced this issue Mar 11, 2024
@mvo5 @ondrejbudai
osbuild: ensure a usable /var/tmp is available inside the buildroot
2f0ed8c 
Colin asked for this in
osbuild/bootc-image-builder#223 and
it's easy enough.
@mvo5
Copy link
Collaborator

mvo5 commented Mar 12, 2024

This is merged now in osbuild/osbuild#1649

@mvo5 mvo5 closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgwalters @mvo5