Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve "shared fragment" issue #3

Open
reidab opened this issue Feb 16, 2014 · 1 comment
Open

Solve "shared fragment" issue #3

reidab opened this issue Feb 16, 2014 · 1 comment

Comments

@reidab
Copy link
Member

reidab commented Feb 16, 2014

Once upon a time, we implemented a system by which OCW would write out the result of rendering layouts/_header.html.erb to a static file, which would then by dynamically included in the osbridge WordPress and Mediawiki themes. As part of work to update things earlier this year, this functionality was removed due to its reliance on heavily-rewritten Rails internals.

This was only ever used by OSB, which is why I'm creating this issue here instead of in the OpenConferenceWare repo.

The importance of this feature is that it allows the other app's navigation to remain consistant, based on the current state of OCW. For example, when the schedule is announced, all of the apps that make up the site need to show a "Schedule" link.

For the CFP open date, we can work around this by writing these partial files manually. After that, we won't have any changes to the navigation until we announce talk selections. By that time, I'd like to have solved this issue.

One option is to reimplement the original functionality using modern Rails practices. Another possibility is to handle the menu rendering in JavaScript, by exposing a JSON endpoint that returns the appropriate menu structure. Additional ideas and hacking are welcome.

@reidab
Copy link
Member Author

reidab commented Mar 5, 2014

When manually writing shared fragments for osbridge, I realized that we either need to move the menu activation JavaScript back into the header or find another way to give that JS to the relying apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant