diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index c601206e..c5a43926 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -29,7 +29,7 @@ jobs: run: | docker network create frontend docker compose run --rm node yarn install - docker compose run --rm node yarn check-coding-standards + docker compose run --rm node yarn check-coding-standards-actions playwright-tests: name: Playwright diff --git a/CHANGELOG.md b/CHANGELOG.md index 74f13a94..64be114e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file. - [#264](https://github.com/os2display/display-admin-client/pull/264) - Added checkbox options component for use in calendar modifiers. - Fixed multiselect when more than one feed source of the given type is installed. + - Fixed github action to fail on warnings. - [#268](https://github.com/os2display/display-admin-client/pull/268) - Added feed source UI. diff --git a/package.json b/package.json index d0879fe0..b27461f6 100644 --- a/package.json +++ b/package.json @@ -48,12 +48,15 @@ "vite": "^5.2.11" }, "scripts": { - "lint:js": "eslint --ext .js --ext .jsx ./src --max-warnings=0", + "lint:js": "eslint --ext .js --ext .jsx ./src", + "lint-actions:js": "eslint --ext .js --ext .jsx ./src --max-warnings=0", "lint:js:fix": "eslint --ext .js --ext .jsx --fix ./src", - "lint:scss": "stylelint \"./src/**/*.scss\" --max-warnings=0", + "lint:scss": "stylelint \"./src/**/*.scss\"", + "lint-actions:scss": "stylelint \"./src/**/*.scss\" --max-warnings=0", "lint:scss:fix": "stylelint --fix \"./src/**/*.scss\"", "check-coding-standards": "yarn lint:js && yarn lint:scss", "apply-coding-standards": "yarn lint:js:fix && yarn lint:scss:fix", + "check-coding-standards-actions": "yarn lint-actions:js && yarn lint-actions:scss", "start": "vite --host 0.0.0.0", "build": "vite build", "preview": "vite preview"