-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/registries config #111
Draft
jpower432
wants to merge
6
commits into
ortelius:main
Choose a base branch
from
jpower432:feat/registries-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
force-pushed
the
feat/registries-config
branch
from
October 18, 2022 19:31
bc10c3a
to
b118146
Compare
jpower432
force-pushed
the
feat/registries-config
branch
from
October 19, 2022 00:08
201c004
to
a9f24cc
Compare
jpower432
force-pushed
the
feat/registries-config
branch
2 times, most recently
from
October 20, 2022 17:29
0d24517
to
8a3ceaa
Compare
@jpower432 It might be helpful for the client to handle the registry config and pass control signalling server. |
jpower432
force-pushed
the
feat/registries-config
branch
2 times, most recently
from
October 20, 2022 19:51
297dc1c
to
bcb798d
Compare
sabre1041
reviewed
Nov 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the functionality works as advertised. @jpower432 can you resolve the conflicts and I'll give it one more test
Allows the registry-config.yaml to be used on the client-side only Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
…idation Signed-off-by: Jennifer Power <[email protected]>
jpower432
force-pushed
the
feat/registries-config
branch
from
November 7, 2022 19:15
c4c269c
to
3d7b1fd
Compare
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to use a registry config with the UOR CLI. This also adds a registry config message to the gRPC API.
This does not include registry mirroring at this point due to security and auth considerations. This will be developed as a follow-on feature.
Fixes #96
Type of change
insecure
flag withskip-tls-verify
How Has This Been Tested?
How to Test
Create a config in the current working directory. Name it
registry-config.yaml
.uor-client-go pull localhost:5000/test:latest -o mydir
[WIP] Feat/add registry config emporous-community/sample-client-go#3
Checklist: