Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/registries config #111

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Oct 17, 2022

Description

Add the ability to use a registry config with the UOR CLI. This also adds a registry config message to the gRPC API.
This does not include registry mirroring at this point due to security and auth considerations. This will be developed as a follow-on feature.

Fixes #96

Type of change

  • New feature
  • Breaking change
    • breaking change on gRPC API (not-released)
    • replaces insecure flag with skip-tls-verify

How Has This Been Tested?

  • Unit Tests added

How to Test

Create a config in the current working directory. Name it registry-config.yaml.

registries:
  - prefix: "localhost:5000"
    skipTLS: false
    plainHTTP: true

uor-client-go pull localhost:5000/test:latest -o mydir

uor-client-go serve test.sock
sample-client pull localhost:5000/test:latest --socket-address test.sock --plain-http

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Requires updates to the Getting Started Guide

@jpower432 jpower432 force-pushed the feat/registries-config branch from bc10c3a to b118146 Compare October 18, 2022 19:31
@jpower432 jpower432 requested a review from afflom October 18, 2022 19:36
@jpower432 jpower432 force-pushed the feat/registries-config branch from 201c004 to a9f24cc Compare October 19, 2022 00:08
@jpower432 jpower432 changed the title [WIP] Feat/registries config Feat/registries config Oct 19, 2022
@jpower432 jpower432 marked this pull request as draft October 20, 2022 12:05
@jpower432 jpower432 changed the title Feat/registries config [WIP] Feat/registries config Oct 20, 2022
@jpower432 jpower432 force-pushed the feat/registries-config branch 2 times, most recently from 0d24517 to 8a3ceaa Compare October 20, 2022 17:29
@afflom
Copy link

afflom commented Oct 20, 2022

@jpower432 It might be helpful for the client to handle the registry config and pass control signalling server.

@jpower432 jpower432 force-pushed the feat/registries-config branch 2 times, most recently from 297dc1c to bcb798d Compare October 20, 2022 19:51
@jpower432 jpower432 changed the title [WIP] Feat/registries config Feat/registries config Oct 20, 2022
@jpower432 jpower432 marked this pull request as ready for review October 20, 2022 20:27
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the functionality works as advertised. @jpower432 can you resolve the conflicts and I'll give it one more test

@jpower432 jpower432 force-pushed the feat/registries-config branch from c4c269c to 3d7b1fd Compare November 7, 2022 19:15
@jpower432 jpower432 requested a review from sabre1041 November 8, 2022 15:11
@jpower432 jpower432 marked this pull request as draft January 26, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Create a configuration file to allow insecure and protocol per registry
3 participants