Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding, custom repo, two machines (including fix) #336

Open
Lilianne-Blaze opened this issue Jan 5, 2024 · 2 comments
Open

Rebuilding, custom repo, two machines (including fix) #336

Lilianne-Blaze opened this issue Jan 5, 2024 · 2 comments

Comments

@Lilianne-Blaze
Copy link
Contributor

There are some problems with rebuilding the plugin.
First, if you have a custom versions of both the plugin and Launch4j and you upload it to your own repo, then try to build a simple demo on another machine it doesn't recognize Launch4j from custom repo. It's there on the disk, but gets ignored.
Second, the LocalArtifactResult.getFile() returns expanded versions, contrary to the comments. I assume it was a bug in Maven that got fixed in the meantime. It resulted in Launch4j being unable to locate one of the exe files.

Here are the quick fixes for both
Lilianne-Blaze@7088cf4
The relevant parts are in Launch4jMojo unpackWorkDir lines 546-628

The tests were on Maven 3.9.1, Liberica JDK 21, Windows 11/10.

@lukaszlenart
Copy link
Collaborator

Would you mind opening a PR with your change?

@Lilianne-Blaze
Copy link
Contributor Author

Added some changes so both fixes run only if previous code failed
2843be0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants