-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit field type registry bug #1074
Comments
Hi @andriusvo, |
@anyt yes, but this is a bug and in any case should be fixed ;) |
|
@anyt Please check |
I see there is a unit test for this method |
It seems the validation message is missliding. According to the test, it throws an exception if you add the type that is already in the map. |
Ok, let me give a real example for you. In
Now, method |
Summary
In class
AuditFieldTypeRegistry
methodvalidateAuditType
works incorrectly.Method
validateAuditType
checks whether provided audit type exists and if it's exist -> exception is raised:Should be:
Steps to reproduce
Use method
addType
to add new type to auditable fields.Actual Result
Exception
Unknown audit type
is raisedExpected Result
New audit type should be added
Details about your environment
The text was updated successfully, but these errors were encountered: