Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webdav encounters 403 authorization error after upgrade to 1.8.29 #403

Open
Forge36 opened this issue Nov 9, 2024 · 6 comments
Open

Webdav encounters 403 authorization error after upgrade to 1.8.29 #403

Forge36 opened this issue Nov 9, 2024 · 6 comments
Labels
bug Something isn't working WebDAV repos

Comments

@Forge36
Copy link

Forge36 commented Nov 9, 2024

Device: Pixel 8a
Android Version: 14
Orgzly Revived Version: 1.8.29
Sync repository type (directory/Dropbox/WebDAV/Git): WebDav

I've downgraded to 1.8.28 and disabled automatic updates in the interim.

Note: I upgraded to 1.8.30 and I'm still seeing the error.

@Forge36 Forge36 added the bug Something isn't working label Nov 9, 2024
amberin added a commit that referenced this issue Nov 10, 2024
…o v0.9"

This reverts commit 94441a1.

The reason is issue #403 -- users have reported problems with 403 errors
since this change.
amberin added a commit that referenced this issue Nov 10, 2024
…o v0.9"

This reverts commit 94441a1.

The reason is issue #403 -- users have reported problems with 403 errors
since this change.
@amberin
Copy link
Member

amberin commented Nov 10, 2024

Thanks for reporting. If you could provide a step-by-step on how to reproduce this error, that would be very valuable. Also, please provide as much technical info as possible about the WebDAV server.

amberin added a commit that referenced this issue Nov 10, 2024
…o v0.9"

This reverts commit 94441a1.

The reason is issue #403 -- users have reported problems with 403 errors
since this change.
@amberin
Copy link
Member

amberin commented Nov 10, 2024

@Forge36 I just built an APK with just the WebDAV library downgraded, if you could try it out, that would be fantastic. To install it, you'll need to download one of the artifacts on this page, unzip the APK, transfer it to your phone and open it. (Or, if you have adb, you can use "adb install <apk filename>".)

@Forge36
Copy link
Author

Forge36 commented Nov 10, 2024

That works!

I'm running

  • DSM 7.1.1-42962 Update 5
  • Synology webDav 2.4.5-10131

As it turns out that's also out of date (but doesn't report so), I'm manually updating my server, which will allow me to update the webDav server.

I'll update if I continue to need the package downgrade after updating my server.

Edit: updating to

  • DSM 7.2.2-72806
  • WebDav 2.4.5-20131

Did not resolve this issue

For reproduction steps, what are you looking for?

@amberin
Copy link
Member

amberin commented Nov 10, 2024

For reproduction, just exactly what you are doing when the problem arises, and exactly what you are seeing. A screenshot is always good.

Obviously, something has changed in the library we depend on, so they could have a bug, and if so we should report it to them.

I'll downgrade the library for the next release, in any case.

@Forge36
Copy link
Author

Forge36 commented Nov 10, 2024

Two workflows tested:

  • Swipe down to refresh from the "Notebooks" menu

image

  • In Settings > Sync > Repositories > WebDAV I tap Test connection

image

I can include full logs via logcat if you'd find those helpful. The only entry that appeared relevant was (adjacent logs not clearly related to sync)

[11-10 10:36:00.306 14307:14415 I/WM-WorkerWrapper]
Worker result FAILURE for Work [ id=98c95830-ddf6-4a7e-93de-67704b6a1023, tags={ com.orgzly.android.sync.SyncWorker } ]

@Forge36
Copy link
Author

Forge36 commented Nov 10, 2024

Looking at the dependency commits:
thegrizzlylabs/sardine-android@v0.8...v0.9

Only two looked functional

thegrizzlylabs/sardine-android@5d7883c

and

thegrizzlylabs/sardine-android@2365354

My URL does not contain spaces or percent encoding. Though I can't rule that out. The exists check is suspect combined with the other issue of some servers reporting 403 for non-existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WebDAV repos
Projects
None yet
Development

No branches or pull requests

2 participants