DataTable change initial sort order

[rho66]

I have a DataTable and a SelectOneRadio component, which is responsible for the initial sort order of the DataTable.
When the page is opened in the browser, the data in the table is sorted according to the initial sort order (Name, Price).
Sorting works also as expected, when I click on any sort marker in the column headers (Code,, Categorty, ...)

The goal is to change the sort order of the table by selecting one of the radio options (e.g. Price, Name).
The listener method onSelectSortOrder() of selectOneRadion is called and changes the priority in List<SortMeta> sortBy but getSortBy() is not called on update. This results in the fact that LazyProductDataModel#load() is still called with the origin sort order.

So any hints welcome how to achieve my goal?
Thnx, Rainer

This is the page:

<h:form id="form">
            <h2 class="mt-0">Sort Order</h2>
            <!-- choose initial sort order -->
            <p:selectOneRadio id="sortOrder" value="#{lazyTableView.sortOrder}" layout="pageDirection">
                <f:selectItem itemLabel="Name, Price" itemValue="1"/>
                <f:selectItem itemLabel="Price, Name" itemValue="2"/>
                <p:ajax listener="#{lazyTableView.onSelectSortOrder}"
                        process="@this"
                        update="@form"/>
            </p:selectOneRadio>
            <p:dataTable id="products"
                         var="product"
                         value="#{lazyTableView.lazyModel}"
                         sortBy="#{lazyTableView.sortBy}"
                         sortMode="multiple"
                         paginator="true" rows="25"
                         paginatorTemplate="{RowsPerPageDropdown} {FirstPageLink} {PreviousPageLink} {CurrentPageReport} {NextPageLink} {LastPageLink}"
                         rowsPerPageTemplate="10,25,50,100">
                <p:column id="colCode" headerText="Code" sortBy="#{product.code}">
                    <h:outputText value="#{product.code}"/>
                </p:column>

                <p:column id="colName" headerText="Name" sortBy="#{product.name}">
                    <h:outputText value="#{product.name}"/>
                </p:column>

                <p:column id="colCategory" headerText="Category" sortBy="#{product.category}">
                    <h:outputText value="#{product.category}"/>
                </p:column>

                <p:column id="colQuantity" headerText="Quantity" sortBy="#{product.quantity}">
                    <h:outputText value="#{product.quantity}"/>
                </p:column>

                <p:column id="colPrice" headerText="Price" sortBy="#{product.price}">
                    <h:outputText value="#{product.price}">
                        <f:convertNumber minFractionDigits="2" maxFractionDigits="2"/>
                    </h:outputText>
                </p:column>
            </p:dataTable>
        </h:form>

This is the backing bean:

@Named
@ViewScoped
public class LazyTableView implements Serializable {
    private LazyDataModel<Product> lazyModel;
    private List<SortMeta> sortBy;
    private String sortOrder;
    private SortMeta sortByName = SortMeta.builder()
            .field("name")
            .order(SortOrder.ASCENDING)
            .build();
    private SortMeta sortByPrice = SortMeta.builder()
            .field("price")
            .order(SortOrder.ASCENDING)
            .build();

    @Inject
    private ProductService service;

    @PostConstruct
    public void init() {
        lazyModel = new LazyProductDataModel(service.getProducts(100));

        // initialize sorting
        sortOrder = "1";
        sortByName.setPriority(1);
        sortByPrice.setPriority(2);
        sortBy = List.of(sortByName, sortByPrice);
    }

    public LazyDataModel<Product> getLazyModel() {
        return lazyModel;
    }

    public List<SortMeta> getSortBy() {
        Logger.debug("-> getSortBy()");
        sortBy.forEach(sm -> Logger.debug(String.format("sortMeta: field=%s, priority=%d",
                sm.getField(),
                sm.getPriority())));
        Logger.debug("<- getSortBy()");
        return sortBy;
    }

    public String getSortOrder() {
        return sortOrder;
    }

    public void setSortOrder(String sortOrder) {
        this.sortOrder = sortOrder;
    }

    public void onSelectSortOrder(AjaxBehaviorEvent event) {
        Logger.debug("-> onSelectSortOrder()");
        if ("1".equals(sortOrder)) {
            // order by name and price
            sortByName.setPriority(1);
            sortByPrice.setPriority(2);
        }
        else {
            // order by price and name
            sortByName.setPriority(2);
            sortByPrice.setPriority(1);
        }
        sortBy = List.of(sortByName, sortByPrice);

        Logger.debug(String.format("onSelectSortOrder(): sortOrder=%s, sortByName.priority=%d, sortByPrice.priority=%d",
                sortOrder, sortByName.getPriority(), sortByPrice.getPriority()));
        Logger.debug("<- onSelectSortOrder()");
    }
}

primefaces-test-export.zip

[Rapster]

I have a feeling it's related to this: primefaces/primefaces#10516 😓

[rho66]

Is it worth to create an issue on primefaces github ?

[Rapster]

Nah we already have several issues linked to this, I also linked this discussion to the ticket so we don't forget about it