Support additional characters in routes #1503
Replies: 6 comments
-
Are you able to make a PR with the required changes in? |
Beta Was this translation helpful? Give feedback.
-
Hello! I don't really know ruby well (or regex) but could you replace that line with something like this: i.e.,
to
|
Beta Was this translation helpful? Give feedback.
-
I realize that's probably only the user section - these might be more appropriate
|
Beta Was this translation helpful? Give feedback.
-
This isn't a bug per-se. Just because special characters are allowed in email addresses doesn't mean a mailbox needs to support those characters. With that said, there's clearly a use case, and I see no reason not to support a reasonable variety of characters. I would suggest that |
Beta Was this translation helpful? Give feedback.
-
I think + should also be supported since many people use the “plus addressing” feature I systems like Gmail and Office 365. |
Beta Was this translation helpful? Give feedback.
-
seeing this has reminded me of #480 (comment) so there be similar use cases |
Beta Was this translation helpful? Give feedback.
-
Route validation doesn't adhere to RFC. I noticed this when trying to add a route with an underscore in the email address. To fix it, I modified this file locally (line 37) and added the underscore:
https://github.com/postalhq/postal/blob/master/app/models/route.rb
But as per RFC, there are many other special characters allowed in the "local part" which this validation will incorrectly return as invaludl. Here's an article which goes into detail: https://help.returnpath.com/hc/en-us/articles/220560587-What-are-the-rules-for-email-address-syntax-
Beta Was this translation helpful? Give feedback.
All reactions