v1.2.0 Proposals - General Fixes and Error Handling

[mochi-co]

v1.2.0 will be ready for release shortly and as mochi-co/mqtt is transitioning from a solo project to a multi-contributor project (🥳 ), I thought it would be a good idea to get a bit more organised.

v1.2.0 contains:

• Support non-UTF8 payloads (per MQTT specification) #29 (@jmacd)
• Replace Travis with Github Actions #41 (@mochi-co)
• docker: add initial simple Dockerfile #57 (@deadprogram)
• Events: Add OnProcessMessage event #53 (@stffabi)
• Add ErrRejectPacket to OnProcessMessage #63 (@mochi-co)
• Configurable Server Options #61 (@mochi-co)
• Improve error handling:
  • Add an OnError handler, report the reason for disconnects #38 (@jmacd)
  • Wrap packet errors with cause information #39 (@jmacd)
• Bug fixes:
  • Release leakable client buffers #67 (@mochi-co)
  • Move two WaitGroup.Add calls #36 @jmacd)
  • Publish: Set the retain flag in the fixedheader #42 (@stffabi)
  • Subscribe: Only send retained messages if ACLs has allowed subscription to the topic #46 (@stffabi)
  • Two no-functional-change cleanups combined #51 (@jmacd)
  • typo #58 (@soyoo)
  • Fix Inflight Persistence Key #62 (@mochi-co)
  • Fix Store Retained Messages #68 (@mochi-co)

[mochi-co]

I think it would be nice to resolve the remaining issues

• client net.Conn in onConnect Hook #21
• Messages with retain only persist once #43
• Use OnMessage to change Retain flag of incoming message #44

as part of v1.2.0, as this would wrap it up nicely.

[jmacd]

Does the change in #38 constitute a breaking API change related to the change of events.Client to events.ClientLike?
I might just-to-be-safe call it 1.2.0, then use 1.3 for the redis changes.

[mochi-co]

I agree - I have renamed it to 1.2.0. Redis persistence can be added as a future minor version. I think clustering needs more serious architectural thought before implementation.