Department Hours form interactivity possible bug

[0ba100]

Hi remdex, great software you have here. Excited to keep using it. I'm not paying for support presently, but I think I may have found a bug.

I've recently run the update script on the lhc instance I installed yesterday. I'm fuzzy on when it started happening, but on the department edit settings screen, selecting the days in the checklist is no longer opening up a form.

I deployed your Digital Ocean setup (very convienient, thank you) and when I first installed it, it was working fine, only this morning it failed to work.

after it stopped working, I ran the update script and cleaned the cache, but saw no change in behavior.

Not sure how helpful this is, but it's seeming like when the change listener is called, day is null in this function:

function changeblock(inst) {
  let day = $(inst).attr("name");
  if ($(inst).is(":checked")) {
    $("." + day + "-block").removeClass("hide");
  } else {
    $("." + day + "-block").addClass("hide");
  }
}

and also, the input itself doesn't seem to have a "name" attribute.

$('input[name="mod"]')
ce.fn.init {length: 0, prevObject: ce.fn.init}

$('input[data-name="mod"]')
ce.fn.init {length: 0, prevObject: ce.fn.init}

I can run $('.mod-block').removeClass('hide'); and it works.

I looked at the code, and found this:

65c6050#r139640717

I hope this is helpful.

[0ba100]

Happy to put in a PR if it's helpful, only it will take me a while to come up with something.

[0ba100]

Looks like form submit is also broken, even when showing the form.

I show the forms, enter data, and click save, no custom time periods show up for my department.

[0ba100]

I switched to using the docker setup on something I already host, and it's completely up to date per doc/CHANGELOG.md, but the behavior still presents.

[remdex]

I find hard to understand what exacrly you want to do. Can you record screen or try reproduce on demo.

[0ba100]

2024-03-12.01-58-18.mp4

Here is screen recording on demo

[remdex]

I see now. Will fix today :)

[remdex]

Fix I have done. New version with bunch of other stuff will be released late today.

[remdex]

And new version with a fix was released :)

[0ba100]

Awesome, Thanks Remdex!