Help with modding paintings 1.18.1

[Dog517]

Hello, so I want to make some paintings for fabric 1.18.1, so I followed a tutorial and set everything up, but in the game when i put down my painting it shows the missing texture. here is my ModPaintings class :

`package net.dogdev.stuffmod.painting;

import net.dogdev.stuffmod.StuffMod;
import net.fabricmc.fabric.api.networking.v1.S2CPlayChannelEvents;
import net.minecraft.entity.decoration.painting.PaintingMotive;
import net.minecraft.util.Identifier;
import net.minecraft.util.registry.Registry;

public class ModPaintings {

public static final PaintingMotive RICK = RegisterPaintings("rick", new PaintingMotive(16,16));



    private static PaintingMotive RegisterPaintings(String name, PaintingMotive paintingMotive){
        return Registry.register(Registry.PAINTING_MOTIVE, new Identifier(StuffMod.MOD_ID, name), paintingMotive);
    }


public static void registerPainting(){

    StuffMod.LOGGER.info("Registering Paintings For " + StuffMod.MOD_ID);

}

}
`

and the structure for the textures is this: resources.assets.stuffmod.textures.painting.rick.png

Thanks!

[warjort]

and the structure for the textures is this: resources.assets.stuffmod.textures.painting.rick.png

If you are following (maven) conventions the png would be in your source tree as
src/main/resources/assets/stuffmod/textures/painting/rick.png
assuming the id is stuffmod:rick
this should be in your mod jar as
assets/stuffmod/textures/painting/rick.png

You can use jar -tf yourmod.jar to look in the jar (in your build/libs) or anything else that lets you look in zip files.

Also try running

                PaintingMotive motive = // the thing you register
		Sprite sprite = MinecraftClient.getInstance().getPaintingManager().getPaintingSprite(motive);

at runtime (after it loads resource packs not at registration time) to see if it actually loaded your image.

[Dog517]

Here, I made a Github repository so you can see if im doing anything wrong.

https://github.com/Dog517/fabric-StuffMod-mod-1.18

[warjort]

This should be "stuffmod"
https://github.com/Dog517/fabric-StuffMod-mod-1.18/blob/26a5cc1e8978ddae1f79934860defd3e237680c5/src/main/java/net/dogdev/stuffmod/StuffMod.java#L20

[Dog517]

This should be "stuffmod" https://github.com/Dog517/fabric-StuffMod-mod-1.18/blob/26a5cc1e8978ddae1f79934860defd3e237680c5/src/main/java/net/dogdev/stuffmod/StuffMod.java#L20

Thanks! for whatever reason this fixed it!

[warjort]

You are using this mod id value as your "namespace" in the identifier when registering the painting.
It must match the "namespace" in your mod's jar otherwise it won't find the file.
Assets have the generic form:
assets/namespace/thing/name.ext

Before it was looking for assets/tutorialmod/textures/painting/rick.png

[Dog517]

Ah.. That makes sense. Thank you for helping me figure it out!