Getting incorrect _instance in WrappedMethodInfo in Diplomacy mod

[bennyz]

Hi,

I'm new to the modding world and I'm trying to get my feet wet by fixing a bug in the Diplomacy mod. The issue is in the kingdom diplomacy view, whenever you perform an action on a selected kingdom, say declaring a war, it will ignore the selected kingdom and will instead use the last kingdom in the list (always Vlandia).

So for example I found where the "Form Alliance" button is called from: https://github.com/DiplomacyTeam/Bannerlord.Diplomacy/blob/f58f9d9261d596c84ee0cee1e4287cdaed88108c/src/Bannerlord.Diplomacy/ViewModelMixin/KingdomTruceItemVmMixin.cs#L385
I see that ViewModel!.Faction2 is always Vlandia, regardless of what is selected, and when I look at the call stack to see what called it I see:

 	Bannerlord.Diplomacy.1.8.0.dll!Diplomacy.ViewModelMixin.KingdomTruceItemVmMixin.FormAlliance() Line 385	C#
 	[Native to Managed Transition]	
 	[Managed to Native Transition]	
>	Bannerlord.UIExtenderEx.dll!Bannerlord.BUTR.Shared.Utils.WrappedMethodInfo.Invoke(object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, object[] parameters, System.Globalization.CultureInfo culture) Line 93	C#
 	TaleWorlds.Library.dll!TaleWorlds.Library.Common.InvokeWithLog(System.Reflection.MethodInfo methodInfo, object obj, object[] args)	Unknown
 	[Lightweight Function]	
 	TaleWorlds.GauntletUI.Data.dll!TaleWorlds.GauntletUI.Data.GauntletView.OnCommand(string command, object[] args)	Unknown
 	TaleWorlds.GauntletUI.dll!TaleWorlds.GauntletUI.BaseTypes.Widget.EventFired(string eventName, object[] args)	Unknown
 	TaleWorlds.GauntletUI.dll!TaleWorlds.GauntletUI.BaseTypes.ButtonWidget.HandleClick()	Unknown
 	TaleWorlds.GauntletUI.dll!TaleWorlds.GauntletUI.BaseTypes.ButtonWidget.OnMouseReleased()	Unknown
 	TaleWorlds.GauntletUI.dll!TaleWorlds.GauntletUI.EventManager.MouseUp()	Unknown
 	TaleWorlds.GauntletUI.dll!TaleWorlds.GauntletUI.UIContext.UpdateInput(TaleWorlds.Library.InputType handleInputs)	Unknown
 	TaleWorlds.ScreenSystem.dll!TaleWorlds.ScreenSystem.ScreenManager.Update()	Unknown
 	[Lightweight Function]	
 	TaleWorlds.Engine.AutoGenerated.dll!ManagedCallbacks.EngineCallb

WrappedMethodInfo.Invoke comes from https://github.com/BUTR/Bannerlord.BUTR.Shared/blob/3d11a8e9303f1c638f716c1bae81bcfcc3f6f850/src/Bannerlord.BUTR.Shared/Utils/WrappedMethodInfo.cs#L92

public override object? Invoke(object? obj, BindingFlags invokeAttr, Binder? binder, object?[]? parameters, CultureInfo? culture) =>
_methodInfoImplementation.Invoke(_instance, invokeAttr, binder, parameters, culture);

When I look with the debugger, I see _instance is Diplomacy.ViewModelMixin.KingdomTruceItemVmMixin, and has the wrong Faction2, while obj is TaleWorlds.CampaignSystem.ViewModelCollection.KingdomManagement.Diplomacy.KingdomTruceItemVM and has the correct Faction2
But I am not sure where this WrappedMethodInfo instance comes from

The reason I am asking in this repository is that the only place I found that creates an instance of WrappedMethodInfo is https://github.com/BUTR/Bannerlord.UIExtenderEx/blob/7ab38c465981e87aa1a846601a8927f2d1bcade4/src/Bannerlord.UIExtenderEx/Components/ViewModelComponent.cs#L134

If there's any pointers on how to debug this further or how to manipulate WrappedMethodInfo, I'd appreciate it.

Thanks!

Edit: version is 1.8.0

[Aragas]

Just to point out. I never managed to understand how to see discussion notifications, so this issue was not seen. @artifixer explained this issue again and I found out that this was a nasty UIExtenderEx bug. Fixed in v2.4.0