Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom ISerializer implementations to be used with SDK #103

Open
brendonofficial opened this issue Feb 10, 2023 · 0 comments
Open

Comments

@brendonofficial
Copy link
Contributor

Currently, the SDK has its own internal instance of NewtonsoftJsonSerializer with hardcoded serializer options configured. This makes it impossible to manipulate the behaviour of (de-)serialized xp objects.

There are a few possible options to address this:

  • use ISerializer instance from DI container (but this possibly interferes with use of OrderCloudContractResolver)
  • use internal serializer for OrderCloud objects, but allow custom ISerializer implementation to be used with xp objects, defaulting to the internal if one is not configured
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant