Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User github flavored markdown parser for mdx files #197

Open
crhistianramirez opened this issue Feb 21, 2020 · 1 comment
Open

User github flavored markdown parser for mdx files #197

crhistianramirez opened this issue Feb 21, 2020 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@crhistianramirez
Copy link
Contributor

This would allow contributors to see what the output should look like for documentation only pages without having to manually build the project

Currently the following code will parse correctly in the project but will exclude anything after the second asterix via github. Kind of a bad example but it demonstrates that the content is being parsed differently than it is on github

`ValueExpression`: *"items.total(product.incategory('Bikes')) \*.15"*

App:
image

Github:
image

@robertsoniv robertsoniv added this to the MVP Fast Follows milestone Feb 24, 2020
@robertsoniv robertsoniv self-assigned this Feb 24, 2020
@robertsoniv
Copy link
Contributor

robertsoniv commented Feb 27, 2020

GitHub is based off of CommonMark which is supposedly true for gatsby-plugin-mdx as well. I have a feeling these subtle differences are due to the fact that we're going from .mdx to HTML vs. plain old .md.

We could probably test this theory by adding a .md file and comparing the rendered output.

@robertsoniv robertsoniv removed this from the MVP Fast Follows milestone Feb 27, 2020
@robertsoniv robertsoniv added the help wanted Extra attention is needed label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants