No Division or Multiplication for a Fraction?

[latenitefilms]

It looks like you can add and subtract a Fraction but not divide or multiply?

Is there any specific reason for this, or is it just not implemented?

[orchetect]

Ah yes - just haven't had a chance to implement yet.

In the meantime you can do one of the following:

• Multiply/divide their doubleValue
  • If the result needs to be a Fraction you can feed the resulting Double value (basically, seconds) into Fraction(double:).
• Multiply/divide their cmTimeValue
  • If the result needs to be a Fraction you can feed the resulting CMTime into Fraction()

[latenitefilms]

No worries - yeah, that was the workaround I was considering, but was worried I might introduce rounding errors, etc.

FWIW - I'm terrible at maths, haha.

[latenitefilms]

Maybe it's something as simple as this?

import Foundation
import TimecodeKit

extension Fraction {
    public static func * (lhs: Self, rhs: Self) -> Self {
        //---------------------------------------------------------
        // Multiply the numerators and denominators:
        //---------------------------------------------------------
        return Fraction(reducing: lhs.numerator * rhs.numerator, lhs.denominator * rhs.denominator)
    }
}

extension Fraction {
    public static func / (lhs: Self, rhs: Self) -> Self {
        //---------------------------------------------------------
        // Check for division by zero scenario:
        //---------------------------------------------------------
        guard rhs.numerator != 0 else {
            fatalError("Division by zero.")
        }

        //---------------------------------------------------------
        // Multiply lhs by the reciprocal of rhs:
        //---------------------------------------------------------
        return Fraction(reducing: lhs.numerator * rhs.denominator, lhs.denominator * rhs.numerator)
    }
}

[orchetect]

In essence yes. I can add that as a co-authored commit to save the trouble of needing a PR.

Also needs corresponding unit tests which I can add.

Included in release 2.0.10.

[latenitefilms]

Apologies for the delayed reply - I missed this.

Amazing, thanks so much!!