Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for 3.2.1 #9

Open
ranadeepak opened this issue Nov 30, 2015 · 2 comments
Open

update for 3.2.1 #9

ranadeepak opened this issue Nov 30, 2015 · 2 comments

Comments

@ranadeepak
Copy link

Hi
I recently upgraded from jstree v3.1.1 to v3.2.1. I was using search plugin with 'show_only_matches' to true. With v3.1.1 it was not displaying the non matching nodes and displaying matching nodes with different css style. But after upgrade to v3.2.1 it is showing all the nodes and matching nodes in different css style.

Note: I am using the latest 'proton' theme avaliable in the repository.

For E.g. if I have following tree str:
A\B\C\USA
A\B\C\Germany
A\B\D\USA2
A\D\India

and user searches for string 'US' the matching nodes were displayed:
A\B\USA //with different css styling
A\B\D\USA2 //with different css styling

But now the tree is displaying as:
A\B\C\USA //with different css styling
A\B\C\Germany
A\B\D\USA2 //with different css styling
A\D

This issue seems like the issue of css files we have. Any plan to update the css files?

@vedraan
Copy link
Contributor

vedraan commented Nov 30, 2015

Hi, we did plan on updating the css files, as to add font-awesome support.

We will update the jsTree dependency as well and will try to look into the show_only_matches plugin problem if there is time.

So far we only really support styling for a couple of plugins you see on the demo and did not do any testing to see how the theme behaves with a wider range of plugins.

@remygrandin
Copy link

I had the same problem, found a (dirty) fix (vakata/jstree#1414)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants