Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CONTRIBUTING.md point out that PR needs to remove GraalVM reachability metadata related to MBeans #133

Closed
linghengqian opened this issue Dec 1, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@linghengqian
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

  • In CONTRIBUTING.md point out that PR needs to remove GraalVM reachability metadata related to MBeans. The following classes seem to cause a lot of misunderstanding, and do not affect nativeTest. The problem is that GraalVM Native Build Tools' Conditional Agent Mode picks up these classes easily.
    • java.lang.management.**
    • jdk.management.**
    • com.sun.management.**
    • sun.management.**
    • javax.management.**

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Null.

Additional context
Add any other context or screenshots about the feature request here.

@linghengqian linghengqian added the enhancement New feature or request label Dec 1, 2022
@mhalbritter
Copy link
Collaborator

Ideally we would have some automated check in place that let's the CI fail if it finds something like this in there. But it should be possible to disable that check if those management classes are really necessary.

@linghengqian
Copy link
Contributor Author

  • I work on this issue.

  • Of course I only work with documents, because to be honest I am a Gradle novice and not sure how to write regular tasks for Github Action.

@linghengqian linghengqian closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants