From c8a1fbb184df8f6b2807c2c716b304dddbd0e894 Mon Sep 17 00:00:00 2001 From: Mahuwa-Barman Date: Tue, 25 Jun 2024 22:25:09 +0530 Subject: [PATCH 1/3] add_validation_for_node_count_secure_mode --- terraform/modules/validators/validators.tf | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/terraform/modules/validators/validators.tf b/terraform/modules/validators/validators.tf index e2c0e72..5fb0160 100644 --- a/terraform/modules/validators/validators.tf +++ b/terraform/modules/validators/validators.tf @@ -83,4 +83,11 @@ locals { invalid_jrf_12c_secure_mode = var.configure_secure_mode && (var.is_oci_db || var.is_atp_db || trimspace(var.oci_db_connection_string) != "") invalid_jrf_12c_secure_mode_msg = "WLSC-ERROR: JRF domain is not supported for FMW 12c version in secured production mode." validate_jrf_12c_secure_mode = local.invalid_jrf_12c_secure_mode ? local.validators_msg_map[local.invalid_jrf_12c_secure_mode_msg] : "" + + invalid_vm_count_provisioning_secure_mode = var.configure_secure_mode && var.provisioned_node_count == 0 && (var.num_vm_instances > 3) + invalid_vm_count_scaleout_secure_mode = var.configure_secure_mode && var.provisioned_node_count > 0 && (var.num_vm_instances - var.provisioned_node_count > 1) + invalid_vm_count_provisioning_secure_mode_msg = "WLSC-ERROR: The value for wls_node_count=[${var.num_vm_instances}] is not valid. The permissible value during provisioning cannot exceed the value 3." + invalid_vm_count_scaleout_secure_mode_msg = "WLSC-ERROR: The value for wls_node_count=[${var.num_vm_instances}] is not valid. The permissible value during scaleout cannot exceed the value [${var.provisioned_node_count + 1}] ." + validate_vm_count_provisioning_secure_mode = local.invalid_vm_count_provisioning_secure_mode ? local.validators_msg_map[local.invalid_vm_count_provisioning_secure_mode_msg] : null + validate_vm_count_scaleout_secure_mode = local.invalid_vm_count_scaleout_secure_mode ? local.validators_msg_map[local.invalid_vm_count_scaleout_secure_mode_msg] : null } From 955c0f6b29dfea19797c690facb0bffd97f47e12 Mon Sep 17 00:00:00 2001 From: Mahuwa-Barman Date: Tue, 25 Jun 2024 22:50:40 +0530 Subject: [PATCH 2/3] add_validation_for_node_count_secure_mode --- terraform/modules/validators/validators.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/terraform/modules/validators/validators.tf b/terraform/modules/validators/validators.tf index 5fb0160..7954cf3 100644 --- a/terraform/modules/validators/validators.tf +++ b/terraform/modules/validators/validators.tf @@ -86,8 +86,8 @@ locals { invalid_vm_count_provisioning_secure_mode = var.configure_secure_mode && var.provisioned_node_count == 0 && (var.num_vm_instances > 3) invalid_vm_count_scaleout_secure_mode = var.configure_secure_mode && var.provisioned_node_count > 0 && (var.num_vm_instances - var.provisioned_node_count > 1) - invalid_vm_count_provisioning_secure_mode_msg = "WLSC-ERROR: The value for wls_node_count=[${var.num_vm_instances}] is not valid. The permissible value during provisioning cannot exceed the value 3." - invalid_vm_count_scaleout_secure_mode_msg = "WLSC-ERROR: The value for wls_node_count=[${var.num_vm_instances}] is not valid. The permissible value during scaleout cannot exceed the value [${var.provisioned_node_count + 1}] ." + invalid_vm_count_provisioning_secure_mode_msg = "WLSC-ERROR: The value for wls_node_count=[${var.num_vm_instances}] is not valid. Provisioning in secured production mode is not supported with more than 4 nodes at a time. So, the value for wls_node_count in this case cannot exceed 3." + invalid_vm_count_scaleout_secure_mode_msg = "WLSC-ERROR: The value for wls_node_count=[${var.num_vm_instances}] is not valid. Scaleout in secured production mode is supported by adding only 1 node at a time. So, the value for wls_node_count in this case cannot exceed [${var.provisioned_node_count + 1}] ." validate_vm_count_provisioning_secure_mode = local.invalid_vm_count_provisioning_secure_mode ? local.validators_msg_map[local.invalid_vm_count_provisioning_secure_mode_msg] : null validate_vm_count_scaleout_secure_mode = local.invalid_vm_count_scaleout_secure_mode ? local.validators_msg_map[local.invalid_vm_count_scaleout_secure_mode_msg] : null } From 5e96b4877a2dc225b17d8dcb22d58b9e4a6714c3 Mon Sep 17 00:00:00 2001 From: Mahuwa-Barman Date: Wed, 26 Jun 2024 10:52:36 +0530 Subject: [PATCH 3/3] add_validation_for_node_count_secure_mode --- terraform/modules/validators/validators.tf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/terraform/modules/validators/validators.tf b/terraform/modules/validators/validators.tf index 7954cf3..ecb7979 100644 --- a/terraform/modules/validators/validators.tf +++ b/terraform/modules/validators/validators.tf @@ -84,6 +84,8 @@ locals { invalid_jrf_12c_secure_mode_msg = "WLSC-ERROR: JRF domain is not supported for FMW 12c version in secured production mode." validate_jrf_12c_secure_mode = local.invalid_jrf_12c_secure_mode ? local.validators_msg_map[local.invalid_jrf_12c_secure_mode_msg] : "" + # Provisioning in secure mode is not supported with more than 3 nodes at a time. + # Scaleout in secure mode is supported by adding only 1 node at a time. invalid_vm_count_provisioning_secure_mode = var.configure_secure_mode && var.provisioned_node_count == 0 && (var.num_vm_instances > 3) invalid_vm_count_scaleout_secure_mode = var.configure_secure_mode && var.provisioned_node_count > 0 && (var.num_vm_instances - var.provisioned_node_count > 1) invalid_vm_count_provisioning_secure_mode_msg = "WLSC-ERROR: The value for wls_node_count=[${var.num_vm_instances}] is not valid. Provisioning in secured production mode is not supported with more than 4 nodes at a time. So, the value for wls_node_count in this case cannot exceed 3."