Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vnic details property in an example packer json template #9

Open
andreww35t opened this issue Feb 25, 2021 · 2 comments
Open

add vnic details property in an example packer json template #9

andreww35t opened this issue Feb 25, 2021 · 2 comments

Comments

@andreww35t
Copy link

andreww35t commented Feb 25, 2021

Would it be possible to improve the packer template so that it contains the create_vnic_details property? The example and doc listed at https://www.packer.io/docs/builders/oracle/oci#create_vnic_details has not worked. I slacked @benofben about this. I will follow up on any potential bug or support elsewhere, but I wanted to possibly help improve the examples. If I get it working, I am happy to submit a pr. TA.

p.s. apologies in advance if this constitutes some etiquette failure.

@zkaufman
Copy link
Contributor

zkaufman commented Feb 25, 2021

@andreww35t Yes please feel free to submit a PR with which contains the create_vnic_details and I will be happy to review and accept (if it works ;)).

Please note that we frequently provide the Quick Start template to partners to facilitate them getting their images and stacks deployed into OCI and OCI Marketplace. For that reason we ask that your code submission err on the side of simplicity and readability whenever reasonable. Thank for the suggested improvement and contributing!

@lucassrg
Copy link
Contributor

Hi @andreww35t, can you please create an issue under the Packer repo since this is an issue very specific to Packer documentation for OCI and not a quickstart related issue.

Please provide the details and error messages so that we can work on identifying the root cause of the issue and provide you a solution.

Thanks,
Lucas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants