Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Page Management - Edit: When saving and there is an error, the Settings tab is selected but the tab panel is not updating the UI. #4778

Open
thabaum opened this issue Oct 24, 2024 · 2 comments

Comments

@thabaum
Copy link
Contributor

thabaum commented Oct 24, 2024

Oqtane Info

Version - 6.0.0
Render Mode - Static
Interactivity - Server
Database - SQL Server

Description

When attempting to save changes within a module (edit page settings), if an error occurs, the "Settings" tab becomes selected, but the corresponding tab panel does not update to reflect the latest user inputs. This leads to user confusion, as they see the "Settings" tab highlighted but the content remains unchanged.

Steps to Reproduce

  1. Navigate to the module with tabbed settings. (Control Panel > Edit Page)
  2. Make changes to the "Settings" input fields that create an error. (blank page name)
  3. Change tabs to "Permissions" tab.
  4. Attempt to save the changes.
  5. Observe that the "Settings" tab is selected after the error, but the content in the UI for that tab does not refresh.

Expected Behavior

  • After encountering a save error, the "Settings" tab should display the most recent input values from the user.
  • The tab panel should refresh to show the updated state of the inputs, even if a save error occurs.

Actual Behavior

  • The "Settings" tab appears active, but the tab panel retains the previous tab input instead of reflecting the current state.

Anything else?

Also notice the 2 tab strip tab panels information when you switch from the "Settings" to "Theme Settings" for example.
image

zyhfish added a commit to zyhfish/oqtane.framework that referenced this issue Nov 7, 2024
@sbwalker
Copy link
Member

sbwalker commented Nov 8, 2024

It may be possible to set the ActiveTab property on the TabStrip during the Save operation?

leigh-pointer added a commit to leigh-pointer/oqtane.framework.fork that referenced this issue Nov 14, 2024
leigh-pointer added a commit to leigh-pointer/oqtane.framework.fork that referenced this issue Nov 14, 2024
leigh-pointer added a commit to leigh-pointer/oqtane.framework.fork that referenced this issue Nov 14, 2024
Modified that TabStrip and TabPane, now when the ActiveTab is changed the TabPanel is selected
sbwalker added a commit that referenced this issue Nov 22, 2024
Fix for Tabpanel is not updating the UI. #4778
leigh-pointer added a commit to leigh-pointer/oqtane.framework.fork that referenced this issue Nov 26, 2024
Fix for Tabpanel is not updating the UI. oqtane#4778 oqtane#4828
sbwalker added a commit that referenced this issue Nov 26, 2024
Revert "Fix for Tabpanel is not updating the UI. #4778"
@sbwalker sbwalker reopened this Nov 26, 2024
@sbwalker
Copy link
Member

Reopening this issue as PR which was intended to resolve this issue had other side effects and has since been reverted.

@thabaum thabaum changed the title [BUG] Page Management - Edit: When saving and there is an error, the Settings tab is selected but teh tab panel is not updating the UI. [BUG] Page Management - Edit: When saving and there is an error, the Settings tab is selected but the tab panel is not updating the UI. Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants