Deleting a Theme does not remove the theme settings.

[leigh-pointer]

After removing a theme from the framework the settings for the theme still remain. These should also be removed.

[sbwalker]

this is a challenge as Theme Settings are not a distinct entity type - they are stored as either Site or Page Settings (depending on the implementation within the Theme). This means there is no explicit way to identify and remove the Theme Settings as they are simply key/value pairs which do not need to follow any naming convention.

[leigh-pointer]

Can we please add Themes to the Entity then? Data redundancy is not good and if a theme is deleted having a Theme entity in use to help this issue.

[sbwalker]

In Oqtane 4.0 the Theme entity is now fully supported - which means you can store Theme settings. However this does not solve the problem you are describing as these Theme settings are global in nature - much the same as ModuleDefinition settings. When applying Theme settings through the UI you are doing so in the context of a Site or Page - which means the settings should be stored in Site settings or Page settings.

[zyhfish]

how about to add a new property "IList SettingKeys" in the ThemeInfo class, then we can remove settings by reading this property value during uninstall process.