Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9630] Fix: Code examples #281

Merged
merged 4 commits into from
Dec 4, 2023
Merged

[FSSDK-9630] Fix: Code examples #281

merged 4 commits into from
Dec 4, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Update README to fix code examples
  • Add sort-packages
  • Add ReturnTypeWillChange decorators

Test plan

  • All existing unit tests and end-to-end FSC tests are expected to pass

Issues

  • FSSDK-9630

@coveralls
Copy link

Coverage Status

coverage: 97.336%. remained the same
when pulling 5d776a7 on fix/example
into 4963820 on master.

@mikechu-optimizely mikechu-optimizely mentioned this pull request Dec 4, 2023
Closed
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review December 4, 2023 21:04
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner December 4, 2023 21:04
mikechu-optimizely
mikechu-optimizely commented Dec 4, 2023
View reviewed changes
Copy link
Contributor Author

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer (advocate) code review completed.

andrewleap-optimizely
andrewleap-optimizely approved these changes Dec 4, 2023
View reviewed changes
Copy link

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit 8fe8574 into master Dec 4, 2023
13 of 14 checks passed
@mikechu-optimizely mikechu-optimizely deleted the fix/example branch December 4, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
chore documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikechu-optimizely @coveralls @andrewleap-optimizely @localheinz