WIP prototype using DataLoader for single_relationship_resolver #5196
+167
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5196 will not alter performanceComparing Summary
|
ajtmccarty
force-pushed
the
ajtm-12112024-gql-single-data-loader
branch
from
00b2397 to
26a928a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#522
IFC-541
structure of the code and location of various classes is definitely not final
a little testing indicates that this approach reduces the number of database calls
we can still end up with multiple similar database calls in a nested query, but I think this might be caused by how we structure our resolvers when building the graphql schema. I'm not entirely sure about the exact cause of this though