Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SEMVER release tasks #5172

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Fixes SEMVER release tasks #5172

merged 8 commits into from
Dec 11, 2024

Conversation

BeArchiTek
Copy link
Contributor

@BeArchiTek BeArchiTek commented Dec 9, 2024

Following https://github.com/opsmill/infrahub/actions/runs/12245552080/job/34159663516, I realized the python semver version doesn't not handle well the pre-release without -. + for docker-compose file and helm chart we actually don't want to have the pre-release identifier as it will be handle with the labels.

@BeArchiTek BeArchiTek requested a review from lykinsbd December 9, 2024 23:15
@BeArchiTek BeArchiTek self-assigned this Dec 9, 2024
@BeArchiTek BeArchiTek added type/housekeeping Maintenance task ci/skip-changelog Don't include this PR in the changelog group/ci Issue related to the CI pipeline labels Dec 9, 2024
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #5172 will not alter performance

Comparing bkr-fix-semver-release-tasks (9a74455) with stable (358575d)

Summary

✅ 10 untouched benchmarks

@BeArchiTek BeArchiTek requested a review from a team December 9, 2024 23:28
@github-actions github-actions bot removed the group/ci Issue related to the CI pipeline label Dec 10, 2024
@BeArchiTek BeArchiTek marked this pull request as draft December 10, 2024 10:26
@BeArchiTek BeArchiTek marked this pull request as ready for review December 10, 2024 17:18
@BeArchiTek BeArchiTek merged commit f91b4e8 into stable Dec 11, 2024
31 of 32 checks passed
@BeArchiTek BeArchiTek deleted the bkr-fix-semver-release-tasks branch December 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-changelog Don't include this PR in the changelog type/housekeeping Maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants