Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a proper error message when executing schema load with the wrong credential #144

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Nov 16, 2024

Fixes #127

I also have a PR coming to improve the error codes and the message returned by the backend

@dgarros dgarros added the type/bug Something isn't working as expected label Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/schema.py 0.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##           stable     #144      +/-   ##
==========================================
- Coverage   65.40%   65.34%   -0.06%     
==========================================
  Files          76       76              
  Lines        6923     6940      +17     
  Branches     1367     1374       +7     
==========================================
+ Hits         4528     4535       +7     
- Misses       2028     2032       +4     
- Partials      367      373       +6     
Flag Coverage Δ
python-3.10 44.32% <0.00%> (-0.08%) ⬇️
python-3.11 44.32% <0.00%> (-0.08%) ⬇️
python-3.12 44.32% <0.00%> (-0.08%) ⬇️
python-3.9 43.44% <0.00%> (-0.08%) ⬇️
python-filler-3.12 23.86% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/schema.py 73.89% <0.00%> (+0.27%) ⬆️

... and 3 files with indirect coverage changes

@dgarros dgarros changed the base branch from develop to stable November 16, 2024 16:39
@dgarros dgarros marked this pull request as ready for review November 16, 2024 16:40
@dgarros dgarros requested a review from a team November 16, 2024 16:40
@dgarros dgarros merged commit b32796f into stable Nov 16, 2024
12 checks passed
@dgarros dgarros deleted the dga-20241116-fix-127 branch November 16, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: Improve error when trying to load a schema without credentials set
2 participants