Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure() executed twice using peaberry activation #79

Open
mcculls opened this issue Jun 22, 2015 · 1 comment
Open

configure() executed twice using peaberry activation #79

mcculls opened this issue Jun 22, 2015 · 1 comment

Comments

@mcculls
Copy link
Member

mcculls commented Jun 22, 2015

Originally reported on Google Code with ID 76

I noticed that when using the peaberry activation extension the configure() method on
the Bundle-Module class is exectuted twice on starting the bundle. Although harmless,
configure() does not have side effects, it is unexpected.

What steps will reproduce the problem?

1. Load peaberry & peaberry-activation modules
2. Load a bundle specifying a Bundle-Module in it's manifest.

What is the expected output? What do you see instead?

Expected configure() to be executed once, instead it is executed two times.

What version of the product are you using? On what operating system?

I'm using peaberry 1.3 and Felix 4.0.3 with Oracle's java 7u10 Linux jvm, x64 edition
on Ubuntu

Please provide any additional information below.

None.

Reported by [email protected] on 2013-01-11 11:22:56

@mcculls
Copy link
Member Author

mcculls commented Jun 22, 2015

#4 alleviates some of these issues by using the TOOL stage when doing the first-pass analysis. Note that the only way to totally remove the need for the two-pass setup would be to use the Guice SPI to analyze, augment, and then replay the binding elements - as I do in https://github.com/eclipse/sisu.inject/blob/master/org.eclipse.sisu.inject/src/org/eclipse/sisu/wire/WireModule.java#L75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant