Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change KarafTestContainer to rely directly on options and KarafPropertiesFile #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

splatch
Copy link
Member

@splatch splatch commented Aug 24, 2013

Please do not merge this pull request yet.

I've created it as entry point for discussion about Pax Exam options used by Karaf test container. In few places we have commas which are simply separators for properties like boot features, repositories and so on. Because of that in many places we need to keep these "," and have values prepended by it. This causes small, but additional effort in test code.

To avoid string glue for boot features and repositories I prepared additional options:

  • KarafBootFeatureOption
  • KarafFeatureRepositoryOption

These options allows to extend bootFeatures and featureRepositories properties in org.apache.karaf.features.cfg file.

Additional option introduced by this commit is LogCategoryLevelOption which allows to specify log4j.logger. property inside org.ops4j.pax.logging.cfg.

During my work on these options I've found that lots of options are handled in manual way - ie. each config option has corresponding method in KarafTestContainer. Amount of code duplicated or very similar there is terrifying. If you don't mean, and if you like the approach of unifying option handling, I would like to refactor it a little bit and then merge this pull request.

@anpieber
Copy link
Member

anpieber commented Nov 6, 2013

as far as good. This is still ops4j though. feel free to go ahead and merge yourself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants