Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Multiple classrooms do not load thumbnails from protos correctly #5631

Open
BenHenning opened this issue Dec 30, 2024 · 3 comments · May be fixed by #5642
Open

[BUG]: Multiple classrooms do not load thumbnails from protos correctly #5631

BenHenning opened this issue Dec 30, 2024 · 3 comments · May be fixed by #5642
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Milestone
1.0 Global availa...

Comments

@BenHenning
Copy link
Member

Describe the bug

When using production assets with thumbnail information, the thumbnails aren't loaded as expected when multiple classrooms is enabled (see screenshot below).

Steps To Reproduce

This requires production assets in order to repro.

Expected Behavior

Thumbnails should load (see screenshot below).

Screenshots/Videos

Thumbnails missing:

image

Thumbnails present (same build and assets but with multiple classrooms disabled):

image

What device/emulator are you using?

Nexus 5X

Which Android version is your device/emulator running?

27

Which version of the Oppia Android app are you using?

0.14-dev-17f2ef3044

Additional Context

No response
@BenHenning BenHenning added bug End user-perceivable behaviors which are not desirable. triage needed labels Dec 30, 2024
@BenHenning
Copy link
Member Author

FYI @theMr17 and @adhiamboperes.

This will likely be a hard GA blocker since we are planning to release the new science classroom for GA.

@BenHenning BenHenning added this to the 1.0 Global availability milestone Dec 30, 2024
@BenHenning
Copy link
Member Author

BenHenning commented Dec 30, 2024 •
edited
Loading

/cc @seanlip as well for potential impact to GA timeline (still needs to be determined), and a heads up that this will result in the 0.14 release going out with multiple classrooms disabled.

@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Dec 30, 2024
@theMr17
Copy link
Collaborator

theMr17 commented Jan 4, 2025

@BenHenning, I looked into the issue, and it seems that the case where images are loaded from the production assets is not being handled. The immediate approach that came to mind is to introduce the glide-compose library and create a custom composable (similar to LessonThumbnailImageView) to handle the loading using the GlideImage component. However, I encountered compatibility issues, as mentioned in #5422 (comment).

@theMr17 theMr17 linked a pull request Jan 6, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
1.0 Global availability
Development

Successfully merging a pull request may close this issue.

Fix #5631: Fix thumbnail loading for multiple classrooms oppia/oppia-android
4 participants
@seanlip @BenHenning @adhiamboperes @theMr17