Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Code Coverage comment fails with disallowed conclusion: action_required #5566

Open
Rd4dev opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@Rd4dev
Copy link
Collaborator

Rd4dev commented Nov 4, 2024

Describe the bug

The PR #5560, #5559 fails to comment the generated code coverage report.

The stack trace mentions:

Error: Run#11587680371 is completed with disallowed conclusion: action_required

Suspect:

Since a review was requested and the trigger relies on the pull request status, it may have marked the action as "required" rather than as a success or failure, which are currently the only two permitted conclusions for the coverage report. (Earlier reviews were submitted as comments, so they didn't lead to this issue.)

Steps To Reproduce

  • Create a PR and request a review
  • Ensure this review is of the type that requires an action ("Request Changes") instead of just adding comments.
  • Once the review is submitted, it should be marked as "action_required" in the comment coverage stack trace

Expected Behavior

It should get a success conclusion and post a coverage comment with the generated coverage data.

Screenshots/Videos

No response

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

No response

Additional Context

Adding "action_required" to the desired conclusions could be a solution if that's the only cause of this issue, yet it need to be validated.

@Rd4dev Rd4dev added bug End user-perceivable behaviors which are not desirable. triage needed labels Nov 4, 2024
@Rd4dev Rd4dev self-assigned this Nov 4, 2024
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed triage needed labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

No branches or pull requests

2 participants