Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Feature flags are failing to log correctly #5556

Open
BenHenning opened this issue Oct 17, 2024 · 1 comment
Open

[BUG]: Feature flags are failing to log correctly #5556

BenHenning opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: High High perceived user impact (breaks a critical feature or blocks a release). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@BenHenning
Copy link
Member

BenHenning commented Oct 17, 2024

Describe the bug

Analyzing the 'feature_flag_list' event in production is showing that feature_flag_names and feature_flag_sync_statuses are both appearing as 'null'. This essentially renders the event unusable since there's no way to correspond event enabled states with the corresponding event.

Steps To Reproduce

Run the following query on the developer Firebase project:

SELECT
(SELECT value.string_value FROM UNNEST(event_params) WHERE key = "uuid") AS uuid,
(SELECT value.string_value FROM UNNEST(event_params) WHERE key = "app_session_id") AS app_session_id,
(SELECT value.string_value FROM UNNEST(event_params) WHERE key = "feature_flag_names") AS feature_flag_names,
(SELECT value.string_value FROM UNNEST(event_params) WHERE key = "feature_flag_enabled_states") AS feature_flag_enabled_states,
(SELECT value.string_value FROM UNNEST(event_params) WHERE key = "feature_flag_sync_statuses") AS feature_flag_sync_statuses,
FROM `oppia-android-dev.analytics_235566504.events_*`
WHERE event_name = "feature_flag_list"

See sample results:

[{
  "uuid": null,
  "app_session_id": "277ed911-efef-3144-b0fa-d37cdd87ac86",
  "feature_flag_names": null,
  "feature_flag_enabled_states": "false,false,false,false,false,false,false,false,false,false,true,false,false",
  "feature_flag_sync_statuses": null
}, {
  "uuid": null,
  "app_session_id": "f2ed5da7-bd3d-3ec3-9044-13ddf766d8fe",
  "feature_flag_names": null,
  "feature_flag_enabled_states": "false,false,false,false,false,false,false,false,false,false,true,false,true",
  "feature_flag_sync_statuses": null
}, {
  "uuid": null,
  "app_session_id": "a41e3a56-4c4a-3a3b-b820-a6337dd5797c",
  "feature_flag_names": null,
  "feature_flag_enabled_states": "false,false,false,false,false,false,false,false,false,false,true,false,true",
  "feature_flag_sync_statuses": null
}]

Expected Behavior

Flag names and sync statuses should successfully log.

Screenshots/Videos

No response

What device/emulator are you using?

No response

Which Android version is your device/emulator running?

No response

Which version of the Oppia Android app are you using?

No response

Additional Context

No response

@BenHenning BenHenning added bug End user-perceivable behaviors which are not desirable. triage needed labels Oct 17, 2024
@BenHenning BenHenning added the Impact: High High perceived user impact (breaks a critical feature or blocks a release). label Oct 17, 2024
@BenHenning BenHenning added this to the 1.0 Global availability milestone Oct 17, 2024
@BenHenning
Copy link
Member Author

@kkmurerwa this is a blocker for app health metrics--it seems that feature flags are not actually logging correctly.

@adhiamboperes adhiamboperes added the Work: Low Solution is clear and broken into good-first-issue-sized chunks. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: High High perceived user impact (breaks a critical feature or blocks a release). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

No branches or pull requests

4 participants