Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units place value is not clearly visible in Rounding Numbers Revision card #4530

Open
KolliAnitha opened this issue Aug 25, 2022 · 7 comments
Open

Units place value is not clearly visible in Rounding Numbers Revision card #4530

KolliAnitha opened this issue Aug 25, 2022 · 7 comments
Assignees
@Vishwajith-Shettigar
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
1.0 Global availa...

Comments

@KolliAnitha
Copy link

KolliAnitha commented Aug 25, 2022 •
edited
Loading

Describe the bug
Units place value is not clearly visible in Rounding Numbers Revision card #4530

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Place Values' - Revision - Select Rounding Numbers
  2. Scroll down to 'Example 1' Lets round the number 95382..
  3. See error

Expected behavior
2 in 95382 should be visible

Demonstration
Screenshot_2022-08-25-09-52-05-50_943a62cb4c6fb83e010e1c2e82766a17.jpg

Environment
Device name: One plus Nord2 5G
Android version : Android 11
App version : 0.8-alpha-091b45a188
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@Yashsomalkar
Copy link

@BenHenning I am having a very bad time serching for this part of the code and file this issue is targeting can u help me with that. Is beta version of the app accessible.

@Yashsomalkar
Copy link

Yashsomalkar commented Oct 10, 2022 •
edited
Loading

I cant reproduce this locally from my forked develop branch . Why is it so ?
@BenHenning @rajat

@BenHenning
Copy link
Member

Hi @Yashsomalkar. This should be reproducible via the beta version of the app (which can be installed by searching for 'Oppia' on the Play Store). That being said, this issue is likely on the harder side, so you may want to consider looking for a different issue to work on if you aren't yet familiar with the codebase.

If you're happy working on this, I can provide some code pointers.

@Yashsomalkar
Copy link

Hi @Yashsomalkar. This should be reproducible via the beta version of the app (which can be installed by searching for 'Oppia' on the Play Store). That being said, this issue is likely on the harder side, so you may want to consider looking for a different issue to work on if you aren't yet familiar with the codebase.

If you're happy working on this, I can provide some code pointers.

Ok i'll find some easier one ig.

@adhiamboperes adhiamboperes self-assigned this Nov 28, 2022
@adhiamboperes adhiamboperes removed their assignment Jan 3, 2023
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added Work: High It's not clear what the solution is. work label added labels May 3, 2023
@Vishwajith-Shettigar
Copy link
Collaborator

This issue might be fixed by PR #5286.

@adhiamboperes
Copy link
Collaborator

This issue might be fixed by PR #5286.

Could you please verify that with screenshots? If fixed can you add this issue number to the PR title and explanation so that it can be closed?

@adhiamboperes adhiamboperes added Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed Work: High It's not clear what the solution is. labels Jan 30, 2024
@Vishwajith-Shettigar
Copy link
Collaborator

This issue might be fixed by PR #5286.

Could you please verify that with screenshots? If fixed can you add this issue number to the PR title and explanation so that it can be closed?

fixedroundingnumbers

Closed
6 tasks
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vishwajith-Shettigar Vishwajith-Shettigar

Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
1.0 Global availability
6 participants
@seanlip @BenHenning @adhiamboperes @Vishwajith-Shettigar @Yashsomalkar @KolliAnitha