Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved popup not shown when opening a file via electron menu or hotkey. #2379

Open
alexzurbonsen opened this issue Dec 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@alexzurbonsen
Copy link
Contributor

Describe the bug
This bug describes the other half of the bug mentioned in #2234.
There are two ways to open a new file:

  1. open file button in the top bar

  2. via the menu option and hotkey
    In both cases the unsaved popup warning should be shown if necessary, before opening a new file.

  3. is taken care of in fix: warn user of unsaved changes if file is opened via button in top bar #2378.

To Reproduce

Steps to reproduce the behavior:

1. Open a file
2. open/create an attribution
3. modify the content, without saving
4. Choose open file option from Electron/Opossum menu (or use respective hotkey)
5. No unsaved popup is shown

Expected behavior
The unsaved pop up should be shown, as well as subsequent warnings that apply if a change is saved (the latter part should already be handled approriately in #2378.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant