diff --git a/pkg/evpn/interface_test.go b/pkg/evpn/interface_test.go index 11d3f248..3a29058c 100644 --- a/pkg/evpn/interface_test.go +++ b/pkg/evpn/interface_test.go @@ -100,15 +100,15 @@ func Test_CreateInterface(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -178,16 +178,18 @@ func Test_DeleteInterface(t *testing.T) { request := &pb.DeleteInterfaceRequest{Name: fname1, AllowMissing: tt.missing} response, err := client.DeleteInterface(ctx, request) - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } + if reflect.TypeOf(response) != reflect.TypeOf(tt.out) { t.Error("response: expected", reflect.TypeOf(tt.out), "received", reflect.TypeOf(response)) } @@ -280,15 +282,15 @@ func Test_UpdateInterface(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -358,15 +360,15 @@ func Test_GetInterface(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } diff --git a/pkg/evpn/svi_subnet_test.go b/pkg/evpn/svi_subnet_test.go index 53eaf74f..95da72ed 100644 --- a/pkg/evpn/svi_subnet_test.go +++ b/pkg/evpn/svi_subnet_test.go @@ -106,15 +106,15 @@ func Test_CreateSubnet(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -184,16 +184,18 @@ func Test_DeleteSubnet(t *testing.T) { request := &pb.DeleteSubnetRequest{Name: fname1, AllowMissing: tt.missing} response, err := client.DeleteSubnet(ctx, request) - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } + if reflect.TypeOf(response) != reflect.TypeOf(tt.out) { t.Error("response: expected", reflect.TypeOf(tt.out), "received", reflect.TypeOf(response)) } @@ -291,15 +293,15 @@ func Test_UpdateSubnet(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -369,15 +371,15 @@ func Test_GetSubnet(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } diff --git a/pkg/evpn/tunnel_vxlan_test.go b/pkg/evpn/tunnel_vxlan_test.go index c80194a7..9e5a9872 100644 --- a/pkg/evpn/tunnel_vxlan_test.go +++ b/pkg/evpn/tunnel_vxlan_test.go @@ -111,15 +111,15 @@ func Test_CreateTunnel(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -189,16 +189,18 @@ func Test_DeleteTunnel(t *testing.T) { request := &pb.DeleteTunnelRequest{Name: fname1, AllowMissing: tt.missing} response, err := client.DeleteTunnel(ctx, request) - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } + if reflect.TypeOf(response) != reflect.TypeOf(tt.out) { t.Error("response: expected", reflect.TypeOf(tt.out), "received", reflect.TypeOf(response)) } @@ -301,15 +303,15 @@ func Test_UpdateTunnel(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -379,15 +381,15 @@ func Test_GetTunnel(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } diff --git a/pkg/evpn/vrf_vpc_test.go b/pkg/evpn/vrf_vpc_test.go index 74f34567..3288f861 100644 --- a/pkg/evpn/vrf_vpc_test.go +++ b/pkg/evpn/vrf_vpc_test.go @@ -100,15 +100,15 @@ func Test_CreateVpc(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -178,16 +178,18 @@ func Test_DeleteVpc(t *testing.T) { request := &pb.DeleteVpcRequest{Name: fname1, AllowMissing: tt.missing} response, err := client.DeleteVpc(ctx, request) - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } + if reflect.TypeOf(response) != reflect.TypeOf(tt.out) { t.Error("response: expected", reflect.TypeOf(tt.out), "received", reflect.TypeOf(response)) } @@ -280,15 +282,15 @@ func Test_UpdateVpc(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) } @@ -358,15 +360,15 @@ func Test_GetVpc(t *testing.T) { } } - if err != nil { - if er, ok := status.FromError(err); ok { - if er.Code() != tt.errCode { - t.Error("error code: expected", tt.errCode, "received", er.Code()) - } - if er.Message() != tt.errMsg { - t.Error("error message: expected", tt.errMsg, "received", er.Message()) - } + if er, ok := status.FromError(err); ok { + if er.Code() != tt.errCode { + t.Error("error code: expected", tt.errCode, "received", er.Code()) + } + if er.Message() != tt.errMsg { + t.Error("error message: expected", tt.errMsg, "received", er.Message()) } + } else { + t.Error("expected grpc error status") } }) }