Remove reminder notification actor

Semantically on the recepient is relevant, as the actor is a reminder
opf · Nov 22, 2024 · 4c01600 · 4c01600
1 parent d6cd810
commit 4c01600
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/app/workers/reminders/schedule_reminder_job.rb b/app/workers/reminders/schedule_reminder_job.rb
@@ -57,7 +57,6 @@ def create_notification_from_reminder(reminder)
       Notifications::CreateService
         .new(user: reminder.creator)
         .call(
-          actor_id: reminder.creator_id,
           recipient_id: reminder.creator_id,
           resource: reminder.remindable,
           reason: :reminder

diff --git a/spec/workers/reminders/schedule_reminder_job_spec.rb b/spec/workers/reminders/schedule_reminder_job_spec.rb
@@ -54,7 +54,6 @@
       aggregate_failures "notification attributes" do
         notification = notification_svc.result
 
-        expect(notification.actor_id).to eq(reminder.creator_id)
         expect(notification.recipient_id).to eq(reminder.creator_id)
         expect(notification.resource).to eq(reminder.remindable)
         expect(notification.reason).to eq("reminder")