This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Rename BundleInstance to BundleDeployment #433
perdasilva
started this conversation in
Ideas
Replies: 3 comments
-
This seems reasonable to me, although I have no strong opinion here. +1 on the change. |
Beta Was this translation helpful? Give feedback.
0 replies
-
This would definitely help with the confusion some of the initial stakeholders have mentioned with respect to this API. It also clearly points to existing Kubernetes concepts. I am also +1 to this. |
Beta Was this translation helpful? Give feedback.
0 replies
-
This was addressed in #436 -- it's now referred to as a BundleDeployment throughout the codebase |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Instance
is a widely used term in programming and from that perspective, having the entrypoint be aBundleInstance
create aBundle
could be a cause for dissonance and make the mental model harder to understand. PerhapsBundleDeployment
would make it easier to understand and fits well with the k8sDeployment
mental model of having a pod spec that creates a pod and a deployment that acts as the top level manager.Beta Was this translation helpful? Give feedback.
All reactions