Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin google.golang.org/grpc from go.mod #3284

Open
perdasilva opened this issue May 27, 2024 · 0 comments
Open

Unpin google.golang.org/grpc from go.mod #3284

perdasilva opened this issue May 27, 2024 · 0 comments
Labels
maintenance Indicates an outstanding maintenance issue with the codebase

Comments

@perdasilva
Copy link
Collaborator

Description

Version 1.64.0 of google.golang.org/grpc changes the way the CatalogSource connection state behaves.
previously it would automatically reach READY - but with the new library, it seems to stay on IDLE unless there is data going down the pipe this is breaking many CatalogSource related e2e-tests and also affecting the way CatalogSource metrics work (since it introduces a more frequent transitions between IDLE and READY the READY/NOTREADY gauges go a bit loopy)

Possible Fixes

Either:

  • A CatalogSourceState of "READY" would now mean gRPC connection state in {READY, IDLE} (unclear whether this makes sense)
  • Or, introduce a periodic health-check (but, Pods already have health-checks!)
  • Or, switch to looking at the pod for CatalogSourceState (i.e. READY == Pod is READY, TRANSIENT_ERROR == Pod not ready) (But, what about the address only CatalogSources...?)
@perdasilva perdasilva added the maintenance Indicates an outstanding maintenance issue with the codebase label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Indicates an outstanding maintenance issue with the codebase
Projects
None yet
Development

No branches or pull requests

1 participant