Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check console version before release #528

Open
qrkourier opened this issue Oct 24, 2024 · 0 comments
Open

check console version before release #528

qrkourier opened this issue Oct 24, 2024 · 0 comments

Comments

@qrkourier
Copy link
Member

Two things need to be bumped when doing a new release to avoid shipping a new version that misrepresents its version in the UI:

  • package.json for ziti-console-lib (the shared library)
  • package.json for ziti-console (the app itself)

ziti-console & ziti-console-lib have different versions and live in different folders, so one way to accomplish this is:

  1. check if files in a project dir have changed in a PR branch based on main
  2. check if there's already a release for the version in each changed project's package.json

If there's already a release for the changed project's version, then fail the check as a way of prompting the developer to bump the version in that project's package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant