Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tasks as failed if no ZIM file was created #723

Open
rgaudin opened this issue Nov 9, 2022 · 3 comments
Open

Mark tasks as failed if no ZIM file was created #723

rgaudin opened this issue Nov 9, 2022 · 3 comments

Comments

@rgaudin
Copy link
Member

rgaudin commented Nov 9, 2022

Sort of a complement of #684 ; if the scraper completes with 0 yet we have not seen any ZIM files, something must be wrong and the task should be marked as failed.
In addition, a log message should be produced with the (recursive ? @kelson42 ?) content of /output so one can check whether something was created (temp ZIM not finished, incorrect extension).

@stale
Copy link

stale bot commented May 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label May 26, 2023
@kelson42 kelson42 added the prio2 label Nov 1, 2023
@stale stale bot removed the stale label Nov 1, 2023
@benoit74
Copy link
Collaborator

Removed from zimit2 project unfortunately

@benoit74
Copy link
Collaborator

benoit74 commented Nov 8, 2024

The fact that we need to mark task as failed when no ZIMs are found has been tackled in #1045

Still need to log the content of output folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants