Fix zimwriterfs usage sample command #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample command output in zimwriterfs command has two issues: - it is not working (anymore?) because it misses the required `--name` parameter - it does not propose a ZIM filename compliant with our conventions This commit fixes both issues.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage 27.54% 27.54%
=======================================
Files 26 26
Lines 2530 2530
Branches 1362 1362
=======================================
Hits 697 697
Misses 1325 1325
Partials 508 508 ☔ View full report in Codecov by Sentry. |
|
@benoit74 Thank you. I will try to fix the CI first, but your PR looks good. |
|
No hurry at all, just an easy fix for a problem I stumbled upon which would have been a shame not to share ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample command output in zimwriterfs command has two issues:
--nameparameterThis PR fixes both issues.