using filesystem read_link to test if sym link already created. #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickhuang99
commented
Jun 21, 2024
nickhuang99
commented
- using std::filesystem's read_link.
- This is an improvement so only test when failure to avoid expensive system call.
- Hopefully this avoid race condition.
nickhuang99
force-pushed
the
testSymlinkAfterFail
branch
from
ba78af8 to
67975bf
Compare
mgautierfr
requested changes
Jul 1, 2024
There was a problem hiding this comment.
On code side, only a small change needed.
On the functionality itself, I'm a bit reluctant as we should not have this kind of situation. If symlinks already exist, there is a lot of probability that contents already exist too. Only checking for symlink is useless here. And if we overwrite content/symlink we should probably have a option at command line level to allow it.
But anyway, even with my concerns, I don't see how this can harm so I will not block this PR.
| @@ -291,6 +292,16 @@ void ZimDumper::writeHttpRedirect(const std::string& directory, const std::strin | |||
| write_to_file(directory + SEPARATOR, outputPath, content.c_str(), content.size()); | |||
| } | |||
|
|
|||
| inline static bool testSymLink(const std::string& sym, const std::string& target) { | |||
There was a problem hiding this comment.
testSymlink convey very few information. (What is tested ?)
It would be better to rename it to checkSymlinkTarget or symlinkPointsTo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.