Remove inline scripts from scraped articles #2111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 75.36% 75.26% -0.11%
==========================================
Files 41 41
Lines 3195 3198 +3
Branches 706 706
==========================================
- Hits 2408 2407 -1
- Misses 670 674 +4
Partials 117 117 ☔ View full report in Codecov by Sentry. |
kelson42
force-pushed
the
remove-inline-script
branch
from
e8aef14 to
7276d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2096
Simply find and remove all script tags from scraped HTML when rendering the article. This doesn't affect "module dependencies", because they are calculated before and re-added later.