Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using the same renderer for all pages (no separate "main page" renderer) #2126

Open
audiodude opened this issue Jan 4, 2025 · 0 comments
Open

Consider using the same renderer for all pages (no separate "main page" renderer) #2126

audiodude opened this issue Jan 4, 2025 · 0 comments
Labels
enhancement question
Milestone
1.15.0

Comments

@audiodude
Copy link
Member

Currently, we branch depending on whether the article isMainPage, and use either the "desktop" class of renderers (if it is), or the "mobile" class of renderers (if it is not).

I confirm this, reason is that (Wikipedia) main page used to look so ugly in mobile view... maybe this could/should be reconsidered because:

  • this software design decision is old
  • it complexifies significantly MWoffliner

Originally posted by @kelson42 in #2090
@kelson42 kelson42 added this to the 1.15.0 milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
2 participants
@audiodude @kelson42