-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal scraper working from end-to-end #1
Conversation
1fb83d3
to
aecd0a3
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
d11f364
to
4f4c5ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished! Most of my comments are on the python side where I have more experience. I did look at the frontends but it's both limited and good looking.
b569a7d
to
46e6072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
46e6072
to
b7edb90
Compare
Fix #2
This is the first PR putting mostly everything in place for this scraper:
End-to-end test:
This will create a
tests_en_libretexts-geo.zim
file inoutput
subfolder, ready to use in kiwix-serve or any other reader.