ZTS block cloning coverage

[oromenahar]

Describe the feature would like to see added to OpenZFS

I'm collecting ideas, to test the ZFS-Block-Cloning feature. Currently there are tests in the test suite for this, but they don't cover everything or every corner case.
To do so, I need ideas what to test.

How I need help?

Please tell me about your daily work with ZFS. What kind of strange file copies do you create and how do you create them? Is the DS encrypted or not. Do you copy the data from a snapshot or from an encrypted clone.
Please provide all the shell commands you use to create source and destination and if you are doing things like renaming a dataset, moving it to a new root or using an encrypted DS please provide the commands for this as well. That makes my life a lot easier to create the tests.

How will this feature improve OpenZFS?

Stability and trust

Additional context

I'm going to add a list of the suggested test. There is a small list in #15544 which is the start point for this Issue. This list will be extended from time to time.

• cloning from non-encrypted to encrypted datasets
• cloning from encrypted to non-encrypted datasets
• cloning from a snapshot dir to a filesystem that is not the source of that snapshot
• cloning from a filesystem created from a snapshot clone to another unrelated dataset
• moving dataset to a new encryption root
• And so on. Probably some positive versions of these too.
• send | recv (change key) -> clone

Thanks for your help. :)

[rincebrain]

Doing anything on FreeBSD would be a start, currently the block cloning tests only run on Linux.

Also I think pjd said something about having a bunch of tests for it, at some point?

Also updating the old fork of xfstests to work again would be good.

Also keep in mind you're likely to hit numerous encryption bugs if you start testing that with send-recv.