Fix to avoid slick() component be created more than once #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippomc
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Code looks good, needed to improve the information provided
@jrmartin for the next PRs the following would really help the review and release process:
- Cite the issue in the PR text (e.g. Closes Fix Query Component's Image Carousel Feature #338)
- Link the PR with the issue (the above should also do that)
- Cite the issue in commit messages, e.g. "Fix Query Component's Image Carousel Feature #338 fixed slick ..."
- Add the issue in the review column in the roadmap project.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem with more than one slick getting created for same ID component. This bug can happen if there's duplicates on the data received by query builder with the same ID, or if the query builder gets resized and component re-rendered.
Closes #338