Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust gradle files for modules preventing Make Project from working. #691

Closed

Conversation

kdeus
Copy link
Contributor

@kdeus kdeus commented Jul 26, 2024

See the associated bug for the error messages.

Tested by:

  • Running Make Project
  • Running Build APKs
  • ./gradlew check

Fixes #690

  • Tests pass

See the associated bug for the error messages.

Tested by:
- Running Make Project
- ./gradlew check

Signed-off-by: Kevin Deus <[email protected]>
@davidz25
Copy link
Contributor

I think a cleaner fix might be to add a dummy test (assertTrue(true) or similar) to commonTest in identity-appsupport?

@kdeus
Copy link
Contributor Author

kdeus commented Jul 26, 2024

I think a cleaner fix might be to add a dummy test (assertTrue(true) or similar) to commonTest in identity-appsupport?

Sounds reasonable. I'm looking into this, but Just adding the test file (and commonTest dependencies in the sourceSet in the Gradle file) isn't sufficient to fix the Cannot locate tasks that match ':identity-appsupport:testClasses'... Gradle error. Seems like there's a missing piece somewhere.

@kdeus
Copy link
Contributor Author

kdeus commented Jul 26, 2024

Adding a test doesn't seem to make much difference.

After doing some more digging, it looks like this is a known issue in this version of Android Studio. Google's recommendation is to add a testClasses task, similar to what I've done.
More info here: https://issuetracker.google.com/issues/292110316#comment16

Another option is upgrading to Android Studio Koala, apparently. I haven't tried that, but this PR would allow our code to work on earlier versions as well.

@davidz25
Copy link
Contributor

I'm using Koala on my Macbook, trying to see if the bug happens there. My intuition is that if it works on Koala maybe that's good enough. I'm not sure it's a very common thing to run "Make Project" from the GUI, most other people just select a target such as "wallet" or some unit tests... and, also, the check and connectedCheck targets pass, we run both via the GitHub workflows...

@kdeus
Copy link
Contributor Author

kdeus commented Jul 31, 2024

I'm using Koala on my Macbook, trying to see if the bug happens there. My intuition is that if it works on Koala maybe that's good enough. I'm not sure it's a very common thing to run "Make Project" from the GUI, most other people just select a target such as "wallet" or some unit tests... and, also, the check and connectedCheck targets pass, we run both via the GitHub workflows...

Make Project exposes the problem, but these are problems in the underlying modules. It isn't possible to build the identity-appsupport module, for instance, without a fix like this (or switching to Koala, if we want to require that).

And the Build APKs command won't work until this is fixed.

@kdeus
Copy link
Contributor Author

kdeus commented Aug 6, 2024

Verified that Build APK, Make Project, and making the individual modules all work fine using Android Studio Koala, without this PR.

Let me know if your preference is to discard this PR. I'm alright with that, if that's the way we'd prefer to go.

@kdeus kdeus closed this Aug 6, 2024
@kdeus kdeus deleted the fix-make-project branch August 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Project and Build APKs fail on Linux.
2 participants