Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin toXxx extensions should be functions not properties #599

Open
davidz25 opened this issue May 8, 2024 · 0 comments
Open

Kotlin toXxx extensions should be functions not properties #599

davidz25 opened this issue May 8, 2024 · 0 comments

Comments

@davidz25
Copy link
Contributor

davidz25 commented May 8, 2024

Pointed out by @GarethCOliver in #595 (comment) and applies to at least ByteArray.{to, From}Hex and ByteArray.{to, From}Base64

davidz25 added a commit that referenced this issue Jun 26, 2024
This is a large mechanical change which changes toHex/fromHex/toBase64
and fromBase64 extension properties to functions. Additionally, it
changes the toDataItem property to be a function. This includes
changes in the processor which generates code.

Fixes Issue #599.

Test: ./gradlew check
Test: ./gradlew connectedCheck
Signed-off-by: David Zeuthen <[email protected]>
sorotokin pushed a commit that referenced this issue Jun 26, 2024
This is a large mechanical change which changes toHex/fromHex/toBase64
and fromBase64 extension properties to functions. Additionally, it
changes the toDataItem property to be a function. This includes
changes in the processor which generates code.

Fixes Issue #599.

Test: ./gradlew check
Test: ./gradlew connectedCheck

Signed-off-by: David Zeuthen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant