Race condition in class Communication in package com.adroid.identity.wallet.transfer

[nicklaswj]

Expected Behavior

The method sendResponse on class Communication with the argument closeAfterSending = true (code), should only close the connection after the deviceResponse message has been sent.

Actual Behavior

If the connection and or latency on the underlying mTransport is slow enough, the above described call will close the connection before the deviceResponse has actually been sent.

Steps to Reproduce the Problem

1. Open either the Purse or Wallet app on a real Phone (for my setup the emulator_speed/internet_speed ratio is too small to cause the race condition).
2. Go to a www-mdl-reader website and open a mdoc url.
3. Press the "Send data" button in the Purse or Wallet app.
4. The www-mdl-reader will receiver no data, since the app closed the connection before the data was sent.

Specifications

• Platform: Android 14 Samsung Galaxy S21 5G

Fix

I'll open a PR with a fix in a minute